Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21733 )
Change subject: IMPALA-13341: Fix mismatch exec option values in py.test files ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21733/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21733/1//COMMIT_MSG@9 PS1, Line 9: add > Nit: added Done http://gerrit.cloudera.org:8080/#/c/21733/1/tests/query_test/test_mem_usage_scaling.py File tests/query_test/test_mem_usage_scaling.py: http://gerrit.cloudera.org:8080/#/c/21733/1/tests/query_test/test_mem_usage_scaling.py@109 PS1, Line 109: # 'test_mem_limit' dimension is defined by subclasses of TestLowMemoryLimits. > We could add a comment stating that "test_mem_limit" is set in subclasses. Done -- To view, visit http://gerrit.cloudera.org:8080/21733 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic34187782c51c6d6fc0a688c9c5f72bf0cb2d45c Gerrit-Change-Number: 21733 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 29 Aug 2024 14:15:52 +0000 Gerrit-HasComments: Yes
