Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21741 )
Change subject: IMPALA-13286: Make stream row counters 64-bit ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/21741/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21741/1//COMMIT_MSG@26 PS1, Line 26: - Ran the previously failed query manually and it completed with the Is there some reason we can't add this query as a regression test? http://gerrit.cloudera.org:8080/#/c/21741/1/be/src/runtime/buffered-tuple-stream.cc File be/src/runtime/buffered-tuple-stream.cc: http://gerrit.cloudera.org:8080/#/c/21741/1/be/src/runtime/buffered-tuple-stream.cc@839 PS1, Line 839: std::min((int64_t)(batch->capacity() - batch->num_rows()), rows_left_in_page); Why do we need the explicit cast, but then don't need a cast when assigning it to rows_to_fill? Also we prefer using static_cast<int64_t>() for these conversions. -- To view, visit http://gerrit.cloudera.org:8080/21741 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d4cf8f424360717de0c4a5571a638a4c11b9606 Gerrit-Change-Number: 21741 Gerrit-PatchSet: 1 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 03 Sep 2024 17:28:36 +0000 Gerrit-HasComments: Yes
