Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21741 )
Change subject: IMPALA-13286: Make stream row counters 64-bit ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21741/2/be/src/runtime/buffered-tuple-stream.cc File be/src/runtime/buffered-tuple-stream.cc: http://gerrit.cloudera.org:8080/#/c/21741/2/be/src/runtime/buffered-tuple-stream.cc@838 PS2, Line 838: int rows_to_fill = static_cast<int>(std::min( : static_cast<int64_t>(batch->capacity() - batch->num_rows()), rows_left_in_page)); : DCHECK_GE(rows_to_fill, 1); Maybe DCHECK against an int64_t variable first before static casting it to int? Also DCHECK that it is indeed less than INT_MAX? -- To view, visit http://gerrit.cloudera.org:8080/21741 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d4cf8f424360717de0c4a5571a638a4c11b9606 Gerrit-Change-Number: 21741 Gerrit-PatchSet: 2 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 11 Sep 2024 15:21:18 +0000 Gerrit-HasComments: Yes
