Xuebin Su has posted comments on this change. ( http://gerrit.cloudera.org:8080/21741 )
Change subject: IMPALA-13286: Make stream row counters 64-bit ...................................................................... Patch Set 2: (2 comments) > Patch Set 1: > > (2 comments) Thanks for reviewing! http://gerrit.cloudera.org:8080/#/c/21741/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21741/1//COMMIT_MSG@26 PS1, Line 26: - Added unit test StreamStateTest::TestAddAndGetZeroSizedRows to ensure > Is there some reason we can't add this query as a regression test? The query can take about 15 mins to complete on my machine since it needs to process billions (UINT_MAX) of rows. I am not sure whether we should add it. In Patch Set 2, I added a new unit test case with mocked long streams so that we can test the corner cases. http://gerrit.cloudera.org:8080/#/c/21741/1/be/src/runtime/buffered-tuple-stream.cc File be/src/runtime/buffered-tuple-stream.cc: http://gerrit.cloudera.org:8080/#/c/21741/1/be/src/runtime/buffered-tuple-stream.cc@839 PS1, Line 839: static_cast<int64_t>(batch->capacity() - batch->num_rows()), rows_left_in_page)); > Why do we need the explicit cast, but then don't need a cast when assigning Thanks! I changed to using static_cast here. We need the explict cast because the types of the two arguments needs to be the same to deduce the template parameter for std::min. We don't need an explicit cast when assigning because the compiler does implict conversions automatically. To warn about implicit conversions, maybe we can add the -Wconversion compiler flag. -- To view, visit http://gerrit.cloudera.org:8080/21741 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d4cf8f424360717de0c4a5571a638a4c11b9606 Gerrit-Change-Number: 21741 Gerrit-PatchSet: 2 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Thu, 05 Sep 2024 03:16:39 +0000 Gerrit-HasComments: Yes
