Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21744 )
Change subject: IMPALA-13347: Fixes TSAN Thread Leak of Workload Management Thread ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/21744/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21744/2//COMMIT_MSG@11 PS2, Line 11: intiated nit: initiated http://gerrit.cloudera.org:8080/#/c/21744/2/be/src/service/workload-management.h File be/src/service/workload-management.h: http://gerrit.cloudera.org:8080/#/c/21744/2/be/src/service/workload-management.h@101 PS2, Line 101: workload management nit: workload management setup http://gerrit.cloudera.org:8080/#/c/21744/2/be/src/service/workload-management.h@108 PS2, Line 108: finishedor nit: finished or http://gerrit.cloudera.org:8080/#/c/21744/2/be/src/service/workload-management.cc File be/src/service/workload-management.cc: http://gerrit.cloudera.org:8080/#/c/21744/2/be/src/service/workload-management.cc@127 PS2, Line 127: workload_management_thread_ Add DCHECK not nullptr. http://gerrit.cloudera.org:8080/#/c/21744/2/be/src/service/workload-management.cc@130 PS2, Line 130: workload_management_thread_->Detach(); Will we miss logging some queries into query log table if this happen? If so, we should log how many queries we might miss after Detach. -- To view, visit http://gerrit.cloudera.org:8080/21744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e95967bb6e04470a8900c9ba69080eea8aaa25e Gerrit-Change-Number: 21744 Gerrit-PatchSet: 3 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 03 Sep 2024 22:54:03 +0000 Gerrit-HasComments: Yes
