Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21744 )
Change subject: IMPALA-13347: Fixes TSAN Thread Leak of Workload Management Thread ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/21744/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21744/2//COMMIT_MSG@10 PS2, Line 10: in impala-server.h. This thread runs until a graceful shutdown is nit: unnecessary double space. Same on the next line. http://gerrit.cloudera.org:8080/#/c/21744/2/be/src/service/workload-management.cc File be/src/service/workload-management.cc: http://gerrit.cloudera.org:8080/#/c/21744/2/be/src/service/workload-management.cc@118 PS2, Line 118: completed_queries_shutdown_cv_.wait_for(l, I'm not quite sure how this works. It holds workload_mgmt_threadstate_mu_ and doesn't release it before signaling. So there's no way another thread could update workload_mgmt_thread_state_ to be SHUTDOWN. So will it always wait the full time? http://gerrit.cloudera.org:8080/#/c/21744/2/be/src/service/workload-management.cc@127 PS2, Line 127: workload_management_thread_ > Add DCHECK not nullptr. Is this ever reached? We should log for both branches. http://gerrit.cloudera.org:8080/#/c/21744/2/be/src/service/workload-management.cc@130 PS2, Line 130: workload_management_thread_->Detach(); > Will we miss logging some queries into query log table if this happen? I agree this would be useful. -- To view, visit http://gerrit.cloudera.org:8080/21744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e95967bb6e04470a8900c9ba69080eea8aaa25e Gerrit-Change-Number: 21744 Gerrit-PatchSet: 4 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 03 Sep 2024 23:01:02 +0000 Gerrit-HasComments: Yes
