Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21777 )
Change subject: IMPALA-13334: Fix test_sort.py DCHECK hit when max_sort_run_size>0 ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/21777/3/be/src/service/query-options-test.cc File be/src/service/query-options-test.cc: http://gerrit.cloudera.org:8080/#/c/21777/3/be/src/service/query-options-test.cc@274 PS3, Line 274: {MAKE_OPTIONDEF(max_sort_run_size), {0, 0}}, : {MAKE_OPTIONDEF(max_sort_run_size), {2, I32_MAX}}, nit: just question, have you consider treating negative and 1 as disabling toggle just like 0, instead of throwing error? That will simplify valid range for this option, right? -- To view, visit http://gerrit.cloudera.org:8080/21777 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I943d8edcc87df168448a174d6c9c6b46fe960eae Gerrit-Change-Number: 21777 Gerrit-PatchSet: 3 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 18 Sep 2024 16:00:13 +0000 Gerrit-HasComments: Yes
