Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21777 )
Change subject: IMPALA-13334: Fix test_sort.py DCHECK hit when max_sort_run_size>0 ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/21777/3/be/src/service/query-options-test.cc File be/src/service/query-options-test.cc: http://gerrit.cloudera.org:8080/#/c/21777/3/be/src/service/query-options-test.cc@274 PS3, Line 274: {MAKE_OPTIONDEF(max_sort_run_size), {0, 0}}, : {MAKE_OPTIONDEF(max_sort_run_size), {2, I32_MAX}}, > So your idea is that the entire range should be considered valid, but value I agree that the value 1 should not be allowed. A user could reasonably think that sort runs of size 1 are okay (but they are actually not). If there is no error, it can lead to confusion that the user thinks the value is set to 1 when it is actually set to some other value. Zero and negative values don't have this problem because it's not reasonable to think that they are valid valid values. -- To view, visit http://gerrit.cloudera.org:8080/21777 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I943d8edcc87df168448a174d6c9c6b46fe960eae Gerrit-Change-Number: 21777 Gerrit-PatchSet: 3 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 24 Sep 2024 14:34:22 +0000 Gerrit-HasComments: Yes
