Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21777 )
Change subject: IMPALA-13334: Fix test_sort.py DCHECK hit when max_sort_run_size>0 ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/21777/3/be/src/runtime/sorter.cc File be/src/runtime/sorter.cc: http://gerrit.cloudera.org:8080/#/c/21777/3/be/src/runtime/sorter.cc@281 PS3, Line 281: MaxSortRunSizeReached() For performance reasons, you could write if (INITIAL_RUN && MaxSortRunSizeReached()) Or, even better, make MaxSortRunSizeReached take INITIAL_RUN as template parameter. AFAICT MaxSortRunSizeReached() is only invoked in context where we already have INITIAL_RUN template parameter: if (MaxSortRunSizeReached<INITIAL_RUN>()) http://gerrit.cloudera.org:8080/#/c/21777/3/be/src/runtime/sorter.cc@299 PS3, Line 299: you could add inline / IR_ALWAYS_INLINE here. -- To view, visit http://gerrit.cloudera.org:8080/21777 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I943d8edcc87df168448a174d6c9c6b46fe960eae Gerrit-Change-Number: 21777 Gerrit-PatchSet: 3 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 26 Sep 2024 14:31:38 +0000 Gerrit-HasComments: Yes
