Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21741 )
Change subject: IMPALA-13286: Make stream row counters 64-bit ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/21741/2/be/src/runtime/buffered-tuple-stream.cc File be/src/runtime/buffered-tuple-stream.cc: http://gerrit.cloudera.org:8080/#/c/21741/2/be/src/runtime/buffered-tuple-stream.cc@838 PS2, Line 838: int64_t rows_to_fill_temp = std::min( : static_cast<int64_t>(batch->capacity() - batch->num_rows()), rows_left_in_page); : DCHECK_LE(rows_to_fill_temp > Thanks! Added a temp int64_t variable and a DCHECK. Done http://gerrit.cloudera.org:8080/#/c/21741/3/be/src/runtime/buffered-tuple-stream.cc File be/src/runtime/buffered-tuple-stream.cc: http://gerrit.cloudera.org:8080/#/c/21741/3/be/src/runtime/buffered-tuple-stream.cc@839 PS3, Line 839: static_cast<int64_t>(batch->capacity() - batch->num_rows()), rows_left_in_page); > nit: if you specified the template parameter, could you skip the static cas Agree, looks cleaner that way. -- To view, visit http://gerrit.cloudera.org:8080/21741 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d4cf8f424360717de0c4a5571a638a4c11b9606 Gerrit-Change-Number: 21741 Gerrit-PatchSet: 3 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 23 Sep 2024 16:26:17 +0000 Gerrit-HasComments: Yes
