Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21754 )
Change subject: IMPALA-12908: Add correctness check for tuple cache ...................................................................... Patch Set 5: Code-Review+1 (11 comments) http://gerrit.cloudera.org:8080/#/c/21754/4/be/src/exec/tuple-cache-node.cc File be/src/exec/tuple-cache-node.cc: http://gerrit.cloudera.org:8080/#/c/21754/4/be/src/exec/tuple-cache-node.cc@89 PS4, Line 89: // was evicted, so we skip the correctness check in this case. > It is possible that after IsAvailableForRead(), the cache metadata is evict Ack http://gerrit.cloudera.org:8080/#/c/21754/4/be/src/exec/tuple-cache-node.cc@92 PS4, Line 92: string ref_sub_dir; > Done Ack http://gerrit.cloudera.org:8080/#/c/21754/4/be/src/exec/tuple-cache-node.cc@97 PS4, Line 97: DCHECK(!ref_sub_dir.empty()); > Done Ack http://gerrit.cloudera.org:8080/#/c/21754/4/be/src/exec/tuple-cache-node.cc@159 PS4, Line 159: } > Done Ack http://gerrit.cloudera.org:8080/#/c/21754/5/be/src/exec/tuple-cache-node.cc File be/src/exec/tuple-cache-node.cc: http://gerrit.cloudera.org:8080/#/c/21754/5/be/src/exec/tuple-cache-node.cc@87 PS5, Line 87: // We need the original fragment id to construct the path for the reference debug Let's LOG(DEBUG) if that happens. http://gerrit.cloudera.org:8080/#/c/21754/4/be/src/exec/tuple-text-file-reader.h File be/src/exec/tuple-text-file-reader.h: http://gerrit.cloudera.org:8080/#/c/21754/4/be/src/exec/tuple-text-file-reader.h@61 PS4, Line 61: std::ifstream reader_; > It seems easier for ifstream to read line from a text file, and for debuggi Ack http://gerrit.cloudera.org:8080/#/c/21754/4/be/src/exec/tuple-text-file-util.cc File be/src/exec/tuple-text-file-util.cc: http://gerrit.cloudera.org:8080/#/c/21754/4/be/src/exec/tuple-text-file-util.cc@85 PS4, Line 85: }; > Done Ack http://gerrit.cloudera.org:8080/#/c/21754/4/be/src/exec/tuple-text-file-writer.h File be/src/exec/tuple-text-file-writer.h: http://gerrit.cloudera.org:8080/#/c/21754/4/be/src/exec/tuple-text-file-writer.h@70 PS4, Line 70: std::ofstream writer_; > If the reader is using ifstream, I might as well use ofstream here. Seems n Ack http://gerrit.cloudera.org:8080/#/c/21754/4/be/src/exec/tuple-text-file-writer.cc File be/src/exec/tuple-text-file-writer.cc: http://gerrit.cloudera.org:8080/#/c/21754/4/be/src/exec/tuple-text-file-writer.cc@37 PS4, Line 37: writer_.open(path_, std::ios::out | std::ios::binary | std::ios::trunc); > Added checks on is_open and fail. Ack http://gerrit.cloudera.org:8080/#/c/21754/5/be/src/exec/tuple-text-file-writer.cc File be/src/exec/tuple-text-file-writer.cc: http://gerrit.cloudera.org:8080/#/c/21754/5/be/src/exec/tuple-text-file-writer.cc@40 PS5, Line 40: "Open tuple text writer on " + path_ + " failed", strerror(errno)); We seem to use both strerror and GetStrErrMsg. GetStrErrMsg comment gives a rationale for preferring it. So let's go with that for now. http://gerrit.cloudera.org:8080/#/c/21754/4/be/src/runtime/tuple-cache-mgr.cc File be/src/runtime/tuple-cache-mgr.cc: http://gerrit.cloudera.org:8080/#/c/21754/4/be/src/runtime/tuple-cache-mgr.cc@376 PS4, Line 376: Status TupleCacheMgr::CreateDebugDumpSubdir(const string& sub_dir) { > Changed a way to implement, basically move the dir creation to the caller s Ack -- To view, visit http://gerrit.cloudera.org:8080/21754 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied074e274ebf99fb57e3ee41a13148725775b77c Gerrit-Change-Number: 21754 Gerrit-PatchSet: 5 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 24 Sep 2024 17:55:41 +0000 Gerrit-HasComments: Yes
