Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21754 )
Change subject: IMPALA-12908: Add correctness check for tuple cache ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/21754/7/be/src/exec/tuple-cache-node.cc File be/src/exec/tuple-cache-node.cc: http://gerrit.cloudera.org:8080/#/c/21754/7/be/src/exec/tuple-cache-node.cc@322 PS7, Line 322: // as the cache may have been evicted. > The handle should keep the cache entry alive. Have we seen cases where it d Yeah, that makes sense, using the handle should help keep the cache entry alive. However, even with the handle, the Open() or GetNext() calls on the reader may fail due to other errors, like https://github.com/apache/impala/blob/3f0a5cc93bb85b86b8fd3d9157de13c4f0174754/be/src/exec/tuple-cache-node.cc#L156. The core question to me is whether we want the correctness check to crash the process in these cases, or if it's better to skip these abnormal scenarios and continue focusing on the overall correctness verification. -- To view, visit http://gerrit.cloudera.org:8080/21754 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied074e274ebf99fb57e3ee41a13148725775b77c Gerrit-Change-Number: 21754 Gerrit-PatchSet: 7 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 25 Sep 2024 23:29:30 +0000 Gerrit-HasComments: Yes
