Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21754 )
Change subject: IMPALA-12908: Add correctness check for tuple cache ...................................................................... Patch Set 6: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/21754/5/be/src/exec/tuple-cache-node.cc File be/src/exec/tuple-cache-node.cc: http://gerrit.cloudera.org:8080/#/c/21754/5/be/src/exec/tuple-cache-node.cc@87 PS5, Line 87: // We need the original fragment id to construct the path for the reference debug > Using a LOG(INFO), probably it is fine, since it rarely prints and only whe Done http://gerrit.cloudera.org:8080/#/c/21754/5/be/src/exec/tuple-text-file-writer.cc File be/src/exec/tuple-text-file-writer.cc: http://gerrit.cloudera.org:8080/#/c/21754/5/be/src/exec/tuple-text-file-writer.cc@40 PS5, Line 40: "Open tuple text writer on " + path_ + " failed", GetStrErrMsg()); > Changed to GetStrErrMsg Done http://gerrit.cloudera.org:8080/#/c/21754/6/be/src/exec/tuple-text-file-writer.cc File be/src/exec/tuple-text-file-writer.cc: http://gerrit.cloudera.org:8080/#/c/21754/6/be/src/exec/tuple-text-file-writer.cc@71 PS6, Line 71: string err_msg = Substitute("Failed to flush $0: $1", path_, GetStrErrMsg()); nit: since this is logging, could skip the Substitute and directly << to the log. -- To view, visit http://gerrit.cloudera.org:8080/21754 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied074e274ebf99fb57e3ee41a13148725775b77c Gerrit-Change-Number: 21754 Gerrit-PatchSet: 6 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 24 Sep 2024 18:32:16 +0000 Gerrit-HasComments: Yes
