Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21780 )
Change subject: IMPALA-13312: Use client address from X-Forwarded-For Header in Ranger Audit Logs ...................................................................... Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/21780/4/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/21780/4/tests/authorization/test_ranger.py@139 PS4, Line 139: \ > flake8: W605 invalid escape sequence '\d' Done http://gerrit.cloudera.org:8080/#/c/21780/4/tests/authorization/test_ranger.py@148 PS4, Line 148: \ > Prefixing the string with 'r' usually remove these warnings. Thanks! http://gerrit.cloudera.org:8080/#/c/21780/4/tests/authorization/test_ranger.py@150 PS4, Line 150: \ > flake8: W605 invalid escape sequence '\)' Done http://gerrit.cloudera.org:8080/#/c/21780/4/tests/authorization/test_ranger.py@152 PS4, Line 152: \ > flake8: W605 invalid escape sequence '\)' Done http://gerrit.cloudera.org:8080/#/c/21780/4/tests/custom_cluster/test_shell_jwt_auth.py File tests/custom_cluster/test_shell_jwt_auth.py: http://gerrit.cloudera.org:8080/#/c/21780/4/tests/custom_cluster/test_shell_jwt_auth.py@92 PS4, Line 92: __assert_log_file > Can these use assert_impalad_log_contains() as well? Fixing in next iteration. http://gerrit.cloudera.org:8080/#/c/21780/4/tests/custom_cluster/test_shell_jwt_auth.py@179 PS4, Line 179: def __assert_log_file(self, log_dir, log_file, expected_strings): > Is this accidentally put back? Fixing in next iteration. -- To view, visit http://gerrit.cloudera.org:8080/21780 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib784ad805c649e9576ef34f125509c904b7773ab Gerrit-Change-Number: 21780 Gerrit-PatchSet: 4 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Thu, 26 Sep 2024 03:03:40 +0000 Gerrit-HasComments: Yes
