Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21780 )

Change subject: IMPALA-13312: Use client address from X-Forwarded-For Header in 
Ranger Audit Logs
......................................................................


Patch Set 4:

(7 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python2 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with virtualenv installed.

http://gerrit.cloudera.org:8080/#/c/21780/4/tests/authorization/test_ranger.py
File tests/authorization/test_ranger.py:

http://gerrit.cloudera.org:8080/#/c/21780/4/tests/authorization/test_ranger.py@139
PS4, Line 139: \
flake8: W605 invalid escape sequence '\d'


http://gerrit.cloudera.org:8080/#/c/21780/4/tests/authorization/test_ranger.py@148
PS4, Line 148: \
flake8: W605 invalid escape sequence '\('


http://gerrit.cloudera.org:8080/#/c/21780/4/tests/authorization/test_ranger.py@148
PS4, Line 148: \
flake8: W605 invalid escape sequence '\)'


http://gerrit.cloudera.org:8080/#/c/21780/4/tests/authorization/test_ranger.py@150
PS4, Line 150: \
flake8: W605 invalid escape sequence '\('


http://gerrit.cloudera.org:8080/#/c/21780/4/tests/authorization/test_ranger.py@150
PS4, Line 150: \
flake8: W605 invalid escape sequence '\)'


http://gerrit.cloudera.org:8080/#/c/21780/4/tests/authorization/test_ranger.py@152
PS4, Line 152: \
flake8: W605 invalid escape sequence '\('


http://gerrit.cloudera.org:8080/#/c/21780/4/tests/authorization/test_ranger.py@152
PS4, Line 152: \
flake8: W605 invalid escape sequence '\)'



--
To view, visit http://gerrit.cloudera.org:8080/21780
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib784ad805c649e9576ef34f125509c904b7773ab
Gerrit-Change-Number: 21780
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Andrew Sherman <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: gaurav singh <[email protected]>
Gerrit-Comment-Date: Thu, 26 Sep 2024 02:47:56 +0000
Gerrit-HasComments: Yes

Reply via email to