Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21780 )
Change subject: IMPALA-13312: Use client address from X-Forwarded-For Header in Ranger Audit Logs ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/21780/3/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/21780/3/tests/authorization/test_ranger.py@135 PS3, Line 135: expected_strings_valid_xff_1 = [ : '"access":"select"', : '"resource":"functional/alltypes"', : '"resType":"@table"', : '"action":"select"', : '"agent":"impala"', : '"enforcer":"ranger-acl"', : '"cliIP":"10.20.30.40"', : '"reqData":"select count(*) from functional.alltypes"', : '"logType":"RangerAudit"' : ] Are these strings exist in single line or multiline? Why not craft regex for this and use existing assert_log_contains()? -- To view, visit http://gerrit.cloudera.org:8080/21780 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib784ad805c649e9576ef34f125509c904b7773ab Gerrit-Change-Number: 21780 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Wed, 25 Sep 2024 16:20:32 +0000 Gerrit-HasComments: Yes
