Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10404 )
Change subject: Put ASAN options in CMakeLists. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10404/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10404/1//COMMIT_MSG@10 PS1, Line 10: to avoid various failures. In particular, backend tests fail > Yes, I'm confused here. My testing missed something; I'm figuring out what. a) seems best to me. We should mention ASAN_OPTIONS in an adjacent comment though so people can find it via grep if they want to override or understand where the values come from. -- To view, visit http://gerrit.cloudera.org:8080/10404 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3cbbd210c67750a48003f336bea1f3e1cb2d9e6b Gerrit-Change-Number: 10404 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 15 May 2018 18:01:26 +0000 Gerrit-HasComments: Yes
