Philip Zeyliger has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10404 )

Change subject: Moving default sanitizer options into init.cc from shell 
scripts.
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/10404/2//COMMIT_MSG
Commit Message:

PS2:
> Should we do this for the other sanitizers, too?
Nice work; you got me to do it. ;)

I'm not aware of automated things that use UBSAN and TSAN for extra testing, 
but I think this is safe enough.

If someone's familiar with a way to check if I'm in a test at runtime, I'm all 
ears. I couldn't bring myself to parse argv[0].


http://gerrit.cloudera.org:8080/#/c/10404/4/be/src/common/init.cc
File be/src/common/init.cc:

http://gerrit.cloudera.org:8080/#/c/10404/4/be/src/common/init.cc@302
PS4, Line 302: string UBSAN_DEFAULT_OPTIONS = Substitute(
> nit: const
Done



--
To view, visit http://gerrit.cloudera.org:8080/10404
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3cbbd210c67750a48003f336bea1f3e1cb2d9e6b
Gerrit-Change-Number: 10404
Gerrit-PatchSet: 4
Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Comment-Date: Thu, 17 May 2018 18:50:16 +0000
Gerrit-HasComments: Yes

Reply via email to