Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10404 )
Change subject: Moving default sanitizer options into init.cc from shell scripts. ...................................................................... Patch Set 5: (2 comments) If this is getting too hairy for UBSAN, feel free to move it back to the shell files. http://gerrit.cloudera.org:8080/#/c/10404/5/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/10404/5/be/src/common/init.cc@302 PS5, Line 302: const string UBSAN_DEFAULT_OPTIONS = Substitute( A couple of other nits I forgot: I think the style guide says to call this kUbsanDefaultOptions and to put it in an unnamed namespace. http://gerrit.cloudera.org:8080/#/c/10404/5/be/src/common/init.cc@305 PS5, Line 305: extern "C" const char *__ubsan_default_options() { Oh, and actually one other thing - how confident are you that this avoids the static initialization order fiasco? https://isocpp.org/wiki/faq/ctors#static-init-order -- To view, visit http://gerrit.cloudera.org:8080/10404 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3cbbd210c67750a48003f336bea1f3e1cb2d9e6b Gerrit-Change-Number: 10404 Gerrit-PatchSet: 5 Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 17 May 2018 19:46:19 +0000 Gerrit-HasComments: Yes
