Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21754 )
Change subject: IMPALA-12908: Add correctness check for tuple cache ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/21754/9/be/src/exec/tuple-cache-node.cc File be/src/exec/tuple-cache-node.cc: http://gerrit.cloudera.org:8080/#/c/21754/9/be/src/exec/tuple-cache-node.cc@341 PS9, Line 341: DCHECK(cache_eos); > How would we reach this with cache_eos==false? The while loop wouldn't have Yeah, previously, we might skip the correctness check, but the current logic is changed. Added DCHECKs, including within the loop, to ensure it doesn't become a dead loop for some cases. -- To view, visit http://gerrit.cloudera.org:8080/21754 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied074e274ebf99fb57e3ee41a13148725775b77c Gerrit-Change-Number: 21754 Gerrit-PatchSet: 10 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 26 Sep 2024 23:09:52 +0000 Gerrit-HasComments: Yes
