Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21754 )
Change subject: IMPALA-12908: Add correctness check for tuple cache ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/21754/7/be/src/exec/tuple-text-file-util-test.cc File be/src/exec/tuple-text-file-util-test.cc: http://gerrit.cloudera.org:8080/#/c/21754/7/be/src/exec/tuple-text-file-util-test.cc@108 PS7, Line 108: vector<string> ref_lines = {"Row 1", "Row 2", "Row 3"}; : vector<string> cmp_lines = {"Row 1", "Row 2"}; : string ref_file = CreateTestFile("ref.txt", ref_lines); : string cmp_file = CreateTestFile("cmp.txt", cmp_lines); : : Status status = TupleTextFileUtil::VerifyRows(ref_file, cmp_file); : EXPECT_FALSE(status.ok()); : EXPECT_EQ(status.code(), TErrorCode::TUPLE_CACHE_INCONSISTENCY); > I don't think that meant to swap the order of the arguments. I read that as Yes, that's what I mean. The ref and cmp paths are slightly different, so for completeness its nice to know this works in both directions. -- To view, visit http://gerrit.cloudera.org:8080/21754 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied074e274ebf99fb57e3ee41a13148725775b77c Gerrit-Change-Number: 21754 Gerrit-PatchSet: 7 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 26 Sep 2024 18:07:16 +0000 Gerrit-HasComments: Yes
