Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21754 )
Change subject: IMPALA-12908: Add correctness check for tuple cache ...................................................................... Patch Set 8: (5 comments) The patch 8 adds a new query option enable_tuple_cache_verification, maybe useful in some tests to control the correct check. http://gerrit.cloudera.org:8080/#/c/21754/4/be/src/exec/tuple-cache-node.cc File be/src/exec/tuple-cache-node.cc: http://gerrit.cloudera.org:8080/#/c/21754/4/be/src/exec/tuple-cache-node.cc@89 PS4, Line 89: if (tuple_cache_mgr->IsAvailableForRead(handle_)) { > When we hold the handle_, the cache entry shouldn't be evicted until we rel Thanks for pointing it out. I changed the logic to return errors if metadata is missing. http://gerrit.cloudera.org:8080/#/c/21754/7/be/src/exec/tuple-cache-node.cc File be/src/exec/tuple-cache-node.cc: http://gerrit.cloudera.org:8080/#/c/21754/7/be/src/exec/tuple-cache-node.cc@194 PS7, Line 194: > It looks like we may not need RuntimeState anymore? Now it is used for TupleCacheVerificationEnabled() http://gerrit.cloudera.org:8080/#/c/21754/7/be/src/exec/tuple-cache-node.cc@322 PS7, Line 322: IncrementNumRowsReturned(num_rows_added); > I am ok with handling the Open failure, but let's print something to the lo I changed all these to return errors, and updated the comments. http://gerrit.cloudera.org:8080/#/c/21754/7/be/src/exec/tuple-text-file-util-test.cc File be/src/exec/tuple-text-file-util-test.cc: http://gerrit.cloudera.org:8080/#/c/21754/7/be/src/exec/tuple-text-file-util-test.cc@108 PS7, Line 108: vector<string> ref_lines = {"Row 1", "Row 2", "Row 3"}; : vector<string> cmp_lines = {"Row 1", "Row 2"}; : string ref_file = CreateTestFile("ref.txt", ref_lines); : string cmp_file = CreateTestFile("cmp.txt", cmp_lines); : : Status status = TupleTextFileUtil::VerifyRows(cmp_file, ref_file); : EXPECT_FALSE(status.ok()); : EXPECT_EQ(status.code(), TErrorCode::TUPLE_CACHE_INCONSISTENCY); > Nit: Could we repeat VerifyRows() in the other direction (i.e. TupleTextFil Done http://gerrit.cloudera.org:8080/#/c/21754/7/be/src/runtime/tuple-cache-mgr.h File be/src/runtime/tuple-cache-mgr.h: http://gerrit.cloudera.org:8080/#/c/21754/7/be/src/runtime/tuple-cache-mgr.h@151 PS7, Line 151: const string& cache_key, const string& fragment_id > Nit: Do you mind if we flip the order of the arguments? Having key, value i Done -- To view, visit http://gerrit.cloudera.org:8080/21754 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied074e274ebf99fb57e3ee41a13148725775b77c Gerrit-Change-Number: 21754 Gerrit-PatchSet: 8 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 26 Sep 2024 17:36:33 +0000 Gerrit-HasComments: Yes
