Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21851 )
Change subject: IMPALA-13389: Refactor all webUI JS to use ES6 syntax ...................................................................... Patch Set 1: (1 comment) > Is there any automation tool to verify JS code style like flake8 is > for python? > > If yes, can you add that tooling into ./bin/jenkins/critique-gerrit-review.py > ? We can integrate ESLint into the python script to have a consistent JS code style. http://gerrit.cloudera.org:8080/#/c/21851/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21851/1//COMMIT_MSG@13 PS1, Line 13: In contrast, now the ES6 syntax with 'let' and 'const' has been used, > How does this impact browser compatibility? When did each major browser sta All the browsers had implemented it fully by 2016. Major JS engines like chromium or spidermonkey had implemented it much earlier. -- To view, visit http://gerrit.cloudera.org:8080/21851 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie38f2c642ede14956a2c6d551a58e42538204768 Gerrit-Change-Number: 21851 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Fri, 27 Sep 2024 09:10:22 +0000 Gerrit-HasComments: Yes
