Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21851 )
Change subject: IMPALA-13389: Refactor all webUI JS to use ES6 syntax ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/21851/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21851/1//COMMIT_MSG@13 PS1, Line 13: In contrast, now the ES6 syntax with 'let' and 'const' has been used, > All the browsers had implemented it fully by 2016. Ack http://gerrit.cloudera.org:8080/#/c/21851/1/www/query_detail_tabs.tmpl File www/query_detail_tabs.tmpl: http://gerrit.cloudera.org:8080/#/c/21851/1/www/query_detail_tabs.tmpl@107 PS1, Line 107: const index = {}; I think changing this to const may have changed it's scope. When I try to load /query_plan, I get an error Uncaught ReferenceError: index is not defined at refresh_record (query_plan?query_id=6a4e1e85e44cdae9:ed00be4700000000:314:24) at XMLHttpRequest.renderGraph (query_plan?query_id=6a4e1e85e44cdae9:ed00be4700000000:501:3) http://gerrit.cloudera.org:8080/#/c/21851/1/www/scripts/query_timeline/host_utilization_diagram.js File www/scripts/query_timeline/host_utilization_diagram.js: http://gerrit.cloudera.org:8080/#/c/21851/1/www/scripts/query_timeline/host_utilization_diagram.js@130 PS1, Line 130: } I'm getting Uncaught SyntaxError: missing ) after argument list (at host_utilization_diagram.js:130:5) here but I don't understand why. -- To view, visit http://gerrit.cloudera.org:8080/21851 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie38f2c642ede14956a2c6d551a58e42538204768 Gerrit-Change-Number: 21851 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Tue, 01 Oct 2024 17:26:45 +0000 Gerrit-HasComments: Yes
