Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21851 )
Change subject: IMPALA-13389: Refactor all webUI JS to use ES6 syntax ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/21851/1/www/query_detail_tabs.tmpl File www/query_detail_tabs.tmpl: http://gerrit.cloudera.org:8080/#/c/21851/1/www/query_detail_tabs.tmpl@107 PS1, Line 107: const index = {}; > I think changing this to const may have changed it's scope. When I try to l Yeah, var is globally scoped while let and const are local/function scope. So this definition is not visible to refresh_record or update_executing_record. http://gerrit.cloudera.org:8080/#/c/21851/1/www/scripts/query_timeline/chart_commons.js File www/scripts/query_timeline/chart_commons.js: http://gerrit.cloudera.org:8080/#/c/21851/1/www/scripts/query_timeline/chart_commons.js@25 PS1, Line 25: export let array_values_start_index = 2; Why is this let if it's never modified? And if it is modified externally, is it safe to use this value in accumulateTimeSeriesValues? -- To view, visit http://gerrit.cloudera.org:8080/21851 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie38f2c642ede14956a2c6d551a58e42538204768 Gerrit-Change-Number: 21851 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Tue, 01 Oct 2024 17:40:49 +0000 Gerrit-HasComments: Yes
