Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21803 )
Change subject: IMPALA-915: Support cancel queries during planning ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/21803/1/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/21803/1/fe/src/main/java/org/apache/impala/service/Frontend.java@2048 PS1, Line 2048: // It's possible that we fail to clear cancelledThreads_ here if: > I'm just saying this is logically correct - we always want to execute this Ok, I think I'll add some logging. After my update, we'll either get: 1. InterruptedException thrown (and not caught), which is returned to the backend as an exception 2. CancelledException thrown, returned to the backend as an exception 3. normal processing I think some of my other new changes in this patch bypass processing the result somehow, as I'm not seeing the exceptions logged anymore. -- To view, visit http://gerrit.cloudera.org:8080/21803 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d25d4c7fb0b8dcc7dad9510db1e8dca220eeb86 Gerrit-Change-Number: 21803 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 27 Sep 2024 16:49:30 +0000 Gerrit-HasComments: Yes
