Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21803 )
Change subject: IMPALA-915: Support cancel queries during planning ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/21803/4/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/21803/4/fe/src/main/java/org/apache/impala/service/Frontend.java@2070 PS4, Line 2070: if (!execRequestThreads_.contains(queryId)) { This is the wrong contains, should be containsKey. http://gerrit.cloudera.org:8080/#/c/21803/4/fe/src/main/java/org/apache/impala/service/Frontend.java@2076 PS4, Line 2076: LOG.debug("Unable to cancel exec request: thread for query {} not found", > May be interesting enough to be at info level? I have a challenge here. Because the QueryDriver is locked until planning completes, I don't have a clean way to test whether planning has completed. Maybe I can come up with something better, but right now this message will have some false positives. -- To view, visit http://gerrit.cloudera.org:8080/21803 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d25d4c7fb0b8dcc7dad9510db1e8dca220eeb86 Gerrit-Change-Number: 21803 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 27 Sep 2024 17:37:18 +0000 Gerrit-HasComments: Yes
