Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21803 )
Change subject: IMPALA-915: Support cancel queries during planning ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/21803/4/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/21803/4/fe/src/main/java/org/apache/impala/service/Frontend.java@2070 PS4, Line 2070: execRequestThread.interrupt(); > This is the wrong contains, should be containsKey. Done http://gerrit.cloudera.org:8080/#/c/21803/4/fe/src/main/java/org/apache/impala/service/Frontend.java@2076 PS4, Line 2076: } > I have a challenge here. Because the QueryDriver is locked until planning c I've cleaned up some of this in my next patch, and updated this. It's pretty unlikely we'll hit this: either 1) we called cancel between RegisterQuery and starting createExecRequest in ExecuteInternal (that's a pretty short window) or 2) createExecRequest just finished but we haven't made it to SetPlanningDone (also a short window). For (1) cancel will take awhile to return, in which case this message can help identify why. For (2) we should cancel right away after, but the occasional extra log message isn't a big deal. -- To view, visit http://gerrit.cloudera.org:8080/21803 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d25d4c7fb0b8dcc7dad9510db1e8dca220eeb86 Gerrit-Change-Number: 21803 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 27 Sep 2024 22:04:22 +0000 Gerrit-HasComments: Yes
