Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/21803 )
Change subject: IMPALA-915: Support cancel queries during planning ...................................................................... Patch Set 7: (1 comment) I am reading along and things are generally looking good http://gerrit.cloudera.org:8080/#/c/21803/7/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/21803/7/be/src/service/client-request-state.cc@1827 PS7, Line 1827: // Used by RETURN_IF_CANCELLED. Nit: I think that previously RETURN_IF_CANCELLED was only applied to RuntimeState? I was confused as RETURN_IF_CANCELLED is in runtime-state.h but now it can be used on ClientReqesyState as well. Nit is to add a comment to RETURN_IF_CANCELLED (which I see is so old it was written by Marcel) -- To view, visit http://gerrit.cloudera.org:8080/21803 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d25d4c7fb0b8dcc7dad9510db1e8dca220eeb86 Gerrit-Change-Number: 21803 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Sat, 28 Sep 2024 00:16:43 +0000 Gerrit-HasComments: Yes
