Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21803 )
Change subject: IMPALA-915: Support cancel queries during planning ...................................................................... Patch Set 9: (2 comments) > Patch Set 9: > > (1 comment) > > This all looks fine, are you still planning to return to the tests? I don't really have other test ideas at the moment. http://gerrit.cloudera.org:8080/#/c/21803/7/tests/custom_cluster/test_local_catalog.py File tests/custom_cluster/test_local_catalog.py: http://gerrit.cloudera.org:8080/#/c/21803/7/tests/custom_cluster/test_local_catalog.py@719 PS7, Line 719: > I haven't figured out how to add a unique delay here. Analysis happens real I didn't find any useful way to test local catalog uniquely, because it doesn't wait on catalogd at all during query compilation. http://gerrit.cloudera.org:8080/#/c/21803/9/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/21803/9/tests/webserver/test_web_pages.py@1028 PS9, Line 1028: Invalidate metadata introduces a delay while catalogd loads metadata > Seems like this is still dependent on timings that may change. They would change if we switched to local catalog mode as the default. I could revisit adding a delay in catalogd, but that would also change with local catalog mode. Tests using a debug action in the coordinator are all pretty much identical, because when the debug action is interrupted Java throws an InterruptedException that propagates up to the JNI interface. -- To view, visit http://gerrit.cloudera.org:8080/21803 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d25d4c7fb0b8dcc7dad9510db1e8dca220eeb86 Gerrit-Change-Number: 21803 Gerrit-PatchSet: 9 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 15 Oct 2024 17:28:04 +0000 Gerrit-HasComments: Yes
