Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10410 )
Change subject: IMPALA-7025: ignore resources in some planner test ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10410/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10410/2//COMMIT_MSG@13 PS2, Line 13: Instead of trying to tweak the test to avoid the issue, instead provide > We need to test the values in the tests that are meant to validate the reso Correct. I'm saying a whitelist may be more robust because it means new tests will by default not validate the mem reservation. The people adding tests around resources will know to enable them :) (but others may not know to disable them in the blacklisting approach) -- To view, visit http://gerrit.cloudera.org:8080/10410 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91e3e416ec6242fbf22d9f566fdd1ce225cb16ac Gerrit-Change-Number: 10410 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 15 May 2018 20:33:41 +0000 Gerrit-HasComments: Yes
