Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10410 )
Change subject: IMPALA-7025: ignore resources in some planner test ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/10410/3/fe/src/test/java/org/apache/impala/testutil/TestUtils.java File fe/src/test/java/org/apache/impala/testutil/TestUtils.java: http://gerrit.cloudera.org:8080/#/c/10410/3/fe/src/test/java/org/apache/impala/testutil/TestUtils.java@110 PS3, Line 110: this.keyPrefix = " " + key + "="; > Why the leading space? This was pretty much just preserved from the previous filters - the idea is just that it should be a separate token rather than a suffix of a different token. E.g. with "size" below we don't want to accidentally ignore foo-size= too. http://gerrit.cloudera.org:8080/#/c/10410/3/fe/src/test/java/org/apache/impala/testutil/TestUtils.java@154 PS3, Line 154: boolean filterFileSize, List<ResultFilter> lineFilters) { > I think we can get rid of the 'filterFileSize' param and change the caller Good point. http://gerrit.cloudera.org:8080/#/c/10410/3/fe/src/test/java/org/apache/impala/testutil/TestUtils.java@179 PS3, Line 179: if (SCAN_RANGE_ROW_COUNT_FILTER.matches(expectedStr)) { > Why not clump them all into one list? Done -- To view, visit http://gerrit.cloudera.org:8080/10410 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91e3e416ec6242fbf22d9f566fdd1ce225cb16ac Gerrit-Change-Number: 10410 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 15 May 2018 22:52:43 +0000 Gerrit-HasComments: Yes
