Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21575 )
Change subject: IMPALA-13221: Calcite: Enable tpcds and tpch queries ...................................................................... Patch Set 9: (22 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/21575/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ConvertToCNFRules.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ConvertToCNFRules.java: http://gerrit.cloudera.org:8080/#/c/21575/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ConvertToCNFRules.java@46 PS9, Line 46: protected static final Logger LOG = LoggerFactory.getLogger(ConvertToCNFRules.class.getName()); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/21575/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ExtractLiteralAgg.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ExtractLiteralAgg.java: http://gerrit.cloudera.org:8080/#/c/21575/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ExtractLiteralAgg.java@51 PS9, Line 51: protected static final Logger LOG = LoggerFactory.getLogger(ExtractLiteralAgg.class.getName()); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/21575/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaMinusToDistinctRule.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaMinusToDistinctRule.java: http://gerrit.cloudera.org:8080/#/c/21575/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaMinusToDistinctRule.java@49 PS9, Line 49: * https://github.com/apache/calcite/blob/main/core/src/main/java/org/apache/calcite/rel/rules/MinusToDistinctRule.java line too long (119 > 90) http://gerrit.cloudera.org:8080/#/c/21575/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaMinusToDistinctRule.java@82 PS9, Line 82: * LogicalAggregate(group=[{0, 1, 2}], agg#0=[COUNT() FILTER $3], agg#1=[COUNT() FILTER $4]) line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/21575/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaMinusToDistinctRule.java@99 PS9, Line 99: protected static final Logger LOG = LoggerFactory.getLogger(ImpalaMinusToDistinctRule.class.getName()); line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/21575/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaMinusToDistinctRule.java@121 PS9, Line 121: // 0 indicates that it comes from the first child branch (operand) of the minus operator line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21575/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaMinusToDistinctRule.java@174 PS9, Line 174: // aggCalls.add(relBuilder.countStar(null).filter(relBuilder.field(originalFieldCnt + i))); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/21575/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaMinusToDistinctRule.java@213 PS9, Line 213: default ImpalaMinusToDistinctRule.Config withOperandFor(Class<? extends Minus> minusClass) { line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/21575/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/util/SimplifiedAnalyzer.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/util/SimplifiedAnalyzer.java: http://gerrit.cloudera.org:8080/#/c/21575/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/util/SimplifiedAnalyzer.java@153 PS9, Line 153: throw new AnalysisException ("Cannot create a unique identifier since it exceeds maximum allowed length"); line too long (114 > 90) http://gerrit.cloudera.org:8080/#/c/21575/9/tests/custom_cluster/test_calcite_tpcds.py File tests/custom_cluster/test_calcite_tpcds.py: http://gerrit.cloudera.org:8080/#/c/21575/9/tests/custom_cluster/test_calcite_tpcds.py@21 PS9, Line 21: import os flake8: F401 'os' imported but unused http://gerrit.cloudera.org:8080/#/c/21575/9/tests/custom_cluster/test_calcite_tpcds.py@22 PS9, Line 22: import pytest flake8: F401 'pytest' imported but unused http://gerrit.cloudera.org:8080/#/c/21575/9/tests/custom_cluster/test_calcite_tpcds.py@23 PS9, Line 23: from copy import deepcopy flake8: F401 'copy.deepcopy' imported but unused http://gerrit.cloudera.org:8080/#/c/21575/9/tests/custom_cluster/test_calcite_tpcds.py@46 PS9, Line 46: @ flake8: E303 too many blank lines (2) http://gerrit.cloudera.org:8080/#/c/21575/9/tests/custom_cluster/test_calcite_tpcds.py@159 PS9, Line 159: flake8: W391 blank line at end of file http://gerrit.cloudera.org:8080/#/c/21575/9/tests/custom_cluster/test_calcite_tpch.py File tests/custom_cluster/test_calcite_tpch.py: http://gerrit.cloudera.org:8080/#/c/21575/9/tests/custom_cluster/test_calcite_tpch.py@20 PS9, Line 20: from builtins import range flake8: F401 'builtins.range' imported but unused http://gerrit.cloudera.org:8080/#/c/21575/9/tests/custom_cluster/test_calcite_tpch.py@21 PS9, Line 21: import pytest flake8: F401 'pytest' imported but unused http://gerrit.cloudera.org:8080/#/c/21575/9/tests/custom_cluster/test_calcite_tpch.py@25 PS9, Line 25: from tests.common.test_dimensions import ( flake8: F401 'tests.common.test_dimensions.create_uncompressed_text_dimension' imported but unused http://gerrit.cloudera.org:8080/#/c/21575/9/tests/custom_cluster/test_calcite_tpch.py@25 PS9, Line 25: from tests.common.test_dimensions import ( flake8: F401 'tests.common.test_dimensions.add_mandatory_exec_option' imported but unused http://gerrit.cloudera.org:8080/#/c/21575/9/tests/custom_cluster/test_calcite_tpch.py@42 PS9, Line 42: class TestTpchQuery(CustomClusterTestSuite): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/21575/9/tests/custom_cluster/test_calcite_tpch.py@55 PS9, Line 55: \ flake8: E502 the backslash is redundant between brackets http://gerrit.cloudera.org:8080/#/c/21575/9/tests/custom_cluster/test_calcite_tpch.py@59 PS9, Line 59: @ flake8: E303 too many blank lines (2) http://gerrit.cloudera.org:8080/#/c/21575/9/tests/custom_cluster/test_calcite_tpch.py@83 PS9, Line 83: flake8: W391 blank line at end of file -- To view, visit http://gerrit.cloudera.org:8080/21575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3107d336ac07ecd89530b640165798ec6a574f41 Gerrit-Change-Number: 21575 Gerrit-PatchSet: 9 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 09 Oct 2024 17:35:26 +0000 Gerrit-HasComments: Yes
