Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21575 )
Change subject: IMPALA-13221: Calcite: Enable tpcds and tpch queries ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/21575/10/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/ImpalaBaseTableRef.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/ImpalaBaseTableRef.java: http://gerrit.cloudera.org:8080/#/c/21575/10/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/util/ImpalaBaseTableRef.java@39 PS10, Line 39: SimplifitedAnalyzer Nit: spelling, SimplifiedAnalyzer http://gerrit.cloudera.org:8080/#/c/21575/10/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ConvertToCNFRules.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ConvertToCNFRules.java: http://gerrit.cloudera.org:8080/#/c/21575/10/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ConvertToCNFRules.java@135 PS10, Line 135: 100 If this works similarly to Impala's existing code, we can use the max_cnf_exprs query option for the limit (which has a default value of 200). -- To view, visit http://gerrit.cloudera.org:8080/21575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3107d336ac07ecd89530b640165798ec6a574f41 Gerrit-Change-Number: 21575 Gerrit-PatchSet: 10 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 10 Oct 2024 03:02:34 +0000 Gerrit-HasComments: Yes
