Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21575 )
Change subject: IMPALA-13221: Calcite: Enable tpcds and tpch queries ...................................................................... Patch Set 11: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/21575/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/util/SimplifiedAnalyzer.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/util/SimplifiedAnalyzer.java: http://gerrit.cloudera.org:8080/#/c/21575/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/util/SimplifiedAnalyzer.java@153 PS11, Line 153: throw new AnalysisException ("Cannot create a unique identifier since it exceeds maximum allowed length"); line too long (114 > 90) http://gerrit.cloudera.org:8080/#/c/21575/11/tests/custom_cluster/test_calcite_tpch.py File tests/custom_cluster/test_calcite_tpch.py: http://gerrit.cloudera.org:8080/#/c/21575/11/tests/custom_cluster/test_calcite_tpch.py@38 PS11, Line 38: class TestTpchQuery(CustomClusterTestSuite): flake8: E302 expected 2 blank lines, found 1 -- To view, visit http://gerrit.cloudera.org:8080/21575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3107d336ac07ecd89530b640165798ec6a574f41 Gerrit-Change-Number: 21575 Gerrit-PatchSet: 11 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 10 Oct 2024 15:24:42 +0000 Gerrit-HasComments: Yes
