Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21911 )
Change subject: IMPALA-13430: Too many RelNodes created for "IN" literals ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21911/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21911/1//COMMIT_MSG@9 PS1, Line 9: The "withCreateValuesRel" config parameter causes a "value" node : to be created for every literal in an "in" clause. This slows down : the compilation time and runtime massively. By removing this : parameter, all literal values are placed within one Values RelNode. We used to be using "withCreateValuesRel(false)" and this changes it to "withCreateValuesRel(true)" to speed things up. Does this comment need to be flipped? -- To view, visit http://gerrit.cloudera.org:8080/21911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc3d84c70af9cd4db44359c4ab7f0c9eb70738f5 Gerrit-Change-Number: 21911 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 10 Oct 2024 04:33:27 +0000 Gerrit-HasComments: Yes
