Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/21911 )
Change subject: IMPALA-13430: Too many RelNodes created for "IN" literals ...................................................................... Patch Set 4: Code-Review+1 (1 comment) I have a suggestion below about improving the code. Doing a +1 for now. Depending on your feedback on this, can bump it up. http://gerrit.cloudera.org:8080/#/c/21911/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java: http://gerrit.cloudera.org:8080/#/c/21911/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java@148 PS4, Line 148: private boolean isCoercedProjectForValues(ParentPlanRelContext context) { > Line 151 looks specifically for the Values node pattern and returns right a Ok, yeah that limits it to only the Project-Values plan; although the second part of my comment was actually more relevant. I understand this current implementation is a hack but it seems a simpler thing would be to just store the Project that was created in CoerceNode.processValues() in a List or a Set in a planner context class and just do a lookup here. The iterating through all the project exprs seems redundant if we have full control over what happens in CoerceNode. -- To view, visit http://gerrit.cloudera.org:8080/21911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc3d84c70af9cd4db44359c4ab7f0c9eb70738f5 Gerrit-Change-Number: 21911 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Sun, 13 Oct 2024 19:31:21 +0000 Gerrit-HasComments: Yes
