Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/21911 )
Change subject: IMPALA-13430: Too many RelNodes created for "IN" literals ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/21911/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java: http://gerrit.cloudera.org:8080/#/c/21911/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java@148 PS4, Line 148: private boolean isCoercedProjectForValues(ParentPlanRelContext context) { The logic in this method is looking for a specific pattern for project expressions but what's the guarantee that the Values rel is the only case where such a pattern occurs ? The number of project expressions could be quite large, so in the worst case, this could be iterating over all of them. Is there a better way to just annotate a Project (or a derived class of Project) sitting above a Values rel ? -- To view, visit http://gerrit.cloudera.org:8080/21911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc3d84c70af9cd4db44359c4ab7f0c9eb70738f5 Gerrit-Change-Number: 21911 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Sat, 12 Oct 2024 22:07:15 +0000 Gerrit-HasComments: Yes
