Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21575 )
Change subject: IMPALA-13221: Calcite: Enable tpcds and tpch queries ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/21575/9/java/calcite-planner/src/main/codegen/templates/Parser.jj File java/calcite-planner/src/main/codegen/templates/Parser.jj: http://gerrit.cloudera.org:8080/#/c/21575/9/java/calcite-planner/src/main/codegen/templates/Parser.jj@4654 PS9, Line 4654: <QUOTED_IDENTIFIER> > I'm going to dump some things here, but I don't know which should influence I did try this original as BIG_QUERY and ran into a problem. This time, I spent some time debugging it, and it turns out the problem was fairly easy to fix. I uploaded a changed version of this file and now escaped quotes should work. http://gerrit.cloudera.org:8080/#/c/21575/10/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ConvertToCNFRules.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ConvertToCNFRules.java: http://gerrit.cloudera.org:8080/#/c/21575/10/java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ConvertToCNFRules.java@135 PS10, Line 135: 100 > Added a Jira to use the query option. The context needs to be available her Hmmmm...I set the value to 200. But when I did this, tpcds q41 was super duper slow. leaving it at 100 allowed the query to finish fairly quickly. -- To view, visit http://gerrit.cloudera.org:8080/21575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3107d336ac07ecd89530b640165798ec6a574f41 Gerrit-Change-Number: 21575 Gerrit-PatchSet: 9 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 10 Oct 2024 18:16:41 +0000 Gerrit-HasComments: Yes
