Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21575 )
Change subject: IMPALA-13221: Calcite: Enable tpcds and tpch queries ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/21575/9/java/calcite-planner/src/main/codegen/templates/Parser.jj File java/calcite-planner/src/main/codegen/templates/Parser.jj: http://gerrit.cloudera.org:8080/#/c/21575/9/java/calcite-planner/src/main/codegen/templates/Parser.jj@4654 PS9, Line 4654: <QUOTED_IDENTIFIER> > I did try this original as BIG_QUERY and ran into a problem. This time, I The latest patch actually has an extra fix. The alias was working for double quotes but not single quotes (i.e. the "as" clause in the select) It should work there now too, and I put in 2 tests into calcite.test -- To view, visit http://gerrit.cloudera.org:8080/21575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3107d336ac07ecd89530b640165798ec6a574f41 Gerrit-Change-Number: 21575 Gerrit-PatchSet: 9 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 10 Oct 2024 20:33:52 +0000 Gerrit-HasComments: Yes
