Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21911 )
Change subject: IMPALA-13430: Too many RelNodes created for "IN" literals ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/21911/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java: http://gerrit.cloudera.org:8080/#/c/21911/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaProjectRel.java@148 PS4, Line 148: private boolean isCoercedProjectForValues(ParentPlanRelContext context) { > Ok, yeah that limits it to only the Project-Values plan; although the secon I don't feel too comfortable keeping RelNode information in a global context. If someone decides to put some rule after the CoerceNodes, it could affect the tree. Sigh, yeah, I hear you about doing the work twice, but it's only in the case where there is a Values node directly underneath. I think it would add a couple milliseconds onto the time, but I don't think it will be that bad, even if there are lots of projects. It's just a quick for loop onto the top layer; it doesn't dig deep into the RexNode or do any real processing. -- To view, visit http://gerrit.cloudera.org:8080/21911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc3d84c70af9cd4db44359c4ab7f0c9eb70738f5 Gerrit-Change-Number: 21911 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Sun, 13 Oct 2024 20:30:57 +0000 Gerrit-HasComments: Yes
