Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19535 )
Change subject: IMPALA-11943: Mark utf8 string functions with IR_ALWAYS_INLINE ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/19535/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19535/3//COMMIT_MSG@28 PS3, Line 28: Ran PERF_STRING queries in targeted-perf (scale factor 100) on parquet : format. Saw significant improvements: Redo the perf-test and updated this part. http://gerrit.cloudera.org:8080/#/c/19535/3//COMMIT_MSG@51 PS3, Line 51: bin/single_node_perf_run.py --iterations 30 --scale 100 \ : --table_for Hard to revert IMPALA-2019 to redo this test now. This part is removed. http://gerrit.cloudera.org:8080/#/c/19535/3/be/src/exprs/mask-functions-ir.cc File be/src/exprs/mask-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/19535/3/be/src/exprs/mask-functions-ir.cc@457 PS3, Line 457: e > Nit: "marked". Done -- To view, visit http://gerrit.cloudera.org:8080/19535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19e8fba332ae329da8b1d37dba3bbc64f59e6f3a Gerrit-Change-Number: 19535 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 14 Oct 2024 22:34:00 +0000 Gerrit-HasComments: Yes
