Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19535 )
Change subject: IMPALA-11943: Mark utf8 string functions with IR_ALWAYS_INLINE ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/19535/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19535/4//COMMIT_MSG@29 PS4, Line 29: Saw significant improvements: yeah, I don't think that we should put more effort to the investigation (revert), it is just a bit sad that we had the right benchmarks to catch this, just didn't run them > We need to improve the job to support larger scale factor For these kind of tests we could also get large row numbers by cross joining with another table, so the actual data on disk wouldn't need to be large. Another thing that could help is is checking some specific counters in the profile.e.g the sum of MaterializeTupleTime if the function is used in WHERE. -- To view, visit http://gerrit.cloudera.org:8080/19535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19e8fba332ae329da8b1d37dba3bbc64f59e6f3a Gerrit-Change-Number: 19535 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 15 Oct 2024 13:02:16 +0000 Gerrit-HasComments: Yes
