Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19535 )
Change subject: IMPALA-11943: Mark utf8 string functions with IR_ALWAYS_INLINE ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/19535/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19535/4//COMMIT_MSG@29 PS4, Line 29: Saw significant improvements: > Nice improvements! Yeah, before we add utf8_mode, string functions like instr() don't need to invoke FunctionContextImpl::GetConstFnAttr(). So this is indeed a fix of the regression. In the previous PS, I verified that the regression is fixed: https://gerrit.cloudera.org/c/19535/3//COMMIT_MSG (the last table) However, it's hard to revert adding utf8_mode (IMPALA-2019) now. So I didn't redo that test and that part is removed. It's a good point to add regularly Jenkins jobs to run these targeted-perf queries. The current perf-AB-test job can only support scale factor <= 42 for tpch dataset. To reveal the improvement, I have to use a larger scale factor (100). We need to improve the job to support larger scale factor, e.g. by loading pre-created parquet files directly. -- To view, visit http://gerrit.cloudera.org:8080/19535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19e8fba332ae329da8b1d37dba3bbc64f59e6f3a Gerrit-Change-Number: 19535 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 15 Oct 2024 09:57:34 +0000 Gerrit-HasComments: Yes
