Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/21927 )
Change subject: IMPALA-13445: Ignore num partition for unpartitioned writes ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21927/1/fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java File fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java: http://gerrit.cloudera.org:8080/#/c/21927/1/fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java@449 PS1, Line 449: if (totalNumPartitions >= maxNumWriters) { : byteBasedNumWriters = maxNumWriters; : } else { : byteBasedNumWriters = (int) totalNumPartitions; : } byteBasedNumWriters value calculated in line 443 is not used for partitioned insert. Are you going to change the behavior for partitioned insert? Or you can move line 441 - 444 in else block. -- To view, visit http://gerrit.cloudera.org:8080/21927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51ab8fc35a5489351a88d372b28642b35449acfc Gerrit-Change-Number: 21927 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 16 Oct 2024 23:53:46 +0000 Gerrit-HasComments: Yes
