Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21927 )
Change subject: IMPALA-13445: Ignore num partition for unpartitioned writes ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/21927/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21927/2//COMMIT_MSG@26 PS2, Line 26: option. > Is it possible to add planner tests? Also for Iceberg tables? Done through tpcds-ddl-iceberg.test. The content is exactly the same as tpcds-ddl-parquet.test. But diffing both will show different mem-estimate between the two. Otherwise, plan structure looks the same. http://gerrit.cloudera.org:8080/#/c/21927/2/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java File fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java: http://gerrit.cloudera.org:8080/#/c/21927/2/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java@245 PS2, Line 245: > Is it possible to have avg row size 0? This was defensive code. I don't think it is possible. Removing it does not seem to impact the calculation (no division by zero). http://gerrit.cloudera.org:8080/#/c/21927/2/fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java File fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java: http://gerrit.cloudera.org:8080/#/c/21927/2/fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java@448 PS2, Line 448: // Utilize all input nodes if possible, but do not schedule more writers than : // partitions. : long minWriters = (int) Math.min(numInputNodes, totalNumPartitions); : long maxWriters = totalNumPartitions; : byteBasedNumWriters = Math.max(minWriters, byteBasedNumWriters); : byteBasedNumWriters = Math.min(maxWriters, byteBasedNumWriters); : } : : // Cap it at most maxNumWriters and at least one writer. : ret > Could it be written as the following? Done -- To view, visit http://gerrit.cloudera.org:8080/21927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51ab8fc35a5489351a88d372b28642b35449acfc Gerrit-Change-Number: 21927 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 17 Oct 2024 20:21:42 +0000 Gerrit-HasComments: Yes
