Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21927 )
Change subject: IMPALA-13445: Ignore num partition for unpartitioned writes ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21927/1/fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java File fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java: http://gerrit.cloudera.org:8080/#/c/21927/1/fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java@449 PS1, Line 449: if (byteBasedNumWriters <= minWriters) { : // Utilize all input nodes if possible. : // This is OK beacuse individual partition most likely is less than : // MIN_WRITE_BYTES. : > byteBasedNumWriters value calculated in line 443 is not used for partitione Thanks for pointing this out. I tweak the algorithm again to seek better performance, but this is still a behavior change for insert + COMPUTE_PROCESSING_COST=1. Please have another look if it make sense or not. -- To view, visit http://gerrit.cloudera.org:8080/21927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51ab8fc35a5489351a88d372b28642b35449acfc Gerrit-Change-Number: 21927 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 17 Oct 2024 04:31:33 +0000 Gerrit-HasComments: Yes
