Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21864 )

Change subject: IMPALA-13340: Fix missing partitions in COPY TESTCASE of 
LocalCatalog mode
......................................................................


Patch Set 6:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/21864/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21864/4//COMMIT_MSG@39
PS4, Line 39: used
> Nit: used
Done


http://gerrit.cloudera.org:8080/#/c/21864/4//COMMIT_MSG@45
PS4, Line 45: thus do not ex
> Not:  should be "thus do not exist"
Done


http://gerrit.cloudera.org:8080/#/c/21864/5/fe/src/main/java/org/apache/impala/catalog/Table.java
File fe/src/main/java/org/apache/impala/catalog/Table.java:

http://gerrit.cloudera.org:8080/#/c/21864/5/fe/src/main/java/org/apache/impala/catalog/Table.java@610
PS5, Line 610:     List<TColumn> columns = new ArrayList<TColumn>();
> nit: unnecessary whitespace change
Done



--
To view, visit http://gerrit.cloudera.org:8080/21864
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc2e8b71564ad37973ddfca92801afea8e26ff73
Gerrit-Change-Number: 21864
Gerrit-PatchSet: 6
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Wed, 30 Oct 2024 10:41:09 +0000
Gerrit-HasComments: Yes

Reply via email to