Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21864 )
Change subject: IMPALA-13340: Fix missing partitions in COPY TESTCASE of LocalCatalog mode ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/21864/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21864/4//COMMIT_MSG@37 PS4, Line 37: When catalogd processes the getPartialCatalog requests on the imported > typo: getPartialCatalog Done http://gerrit.cloudera.org:8080/#/c/21864/4//COMMIT_MSG@49 PS4, Line 49: Tests > Should there also be a new LocalCatalog mode test? The existing test runs in both modes. The dockerised-tests use LocalCatalog mode by default. That's how we captured the bugs in PS1. I left a comment about it. http://gerrit.cloudera.org:8080/#/c/21864/4/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java File fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java: http://gerrit.cloudera.org:8080/#/c/21864/4/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@1074 PS4, Line 1074: // don't have partition metadata. > The comment is no longer clear, since we don't check cachedMsPartitionDescr Done http://gerrit.cloudera.org:8080/#/c/21864/4/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/21864/4/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@543 PS4, Line 543: !tableId.equalsIgnoreCase( > nit: could this change be less invasive if loadedInImpalad were a property Good point! Done. -- To view, visit http://gerrit.cloudera.org:8080/21864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc2e8b71564ad37973ddfca92801afea8e26ff73 Gerrit-Change-Number: 21864 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 28 Oct 2024 05:27:52 +0000 Gerrit-HasComments: Yes
