Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21864 )
Change subject: IMPALA-13340: Fix missing partitions in COPY TESTCASE of LocalCatalog mode ...................................................................... Patch Set 5: Code-Review+2 (4 comments) http://gerrit.cloudera.org:8080/#/c/21864/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21864/4//COMMIT_MSG@39 PS4, Line 39: uses Nit: used http://gerrit.cloudera.org:8080/#/c/21864/4//COMMIT_MSG@45 PS4, Line 45: thus not exist Not: should be "thus do not exist" http://gerrit.cloudera.org:8080/#/c/21864/2/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/21864/2/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@1109 PS2, Line 1109: %s", part) > This is helpful to print what the partition in the response looks like. So Done http://gerrit.cloudera.org:8080/#/c/21864/2/tests/metadata/test_testcase_builder.py File tests/metadata/test_testcase_builder.py: http://gerrit.cloudera.org:8080/#/c/21864/2/tests/metadata/test_testcase_builder.py@70 PS2, Line 70: {"PLANNER_TESTCASE_MODE": True}) > Partition ids are not exposed to the clients. But we can get it from the "/ Done -- To view, visit http://gerrit.cloudera.org:8080/21864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc2e8b71564ad37973ddfca92801afea8e26ff73 Gerrit-Change-Number: 21864 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 29 Oct 2024 21:45:15 +0000 Gerrit-HasComments: Yes
